Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable breaking markdown links #2882

Closed
tg-x opened this issue Apr 15, 2020 · 4 comments
Closed

Add option to disable breaking markdown links #2882

tg-x opened this issue Apr 15, 2020 · 4 comments

Comments

@tg-x
Copy link

tg-x commented Apr 15, 2020

Grav breaks links by removing certain attributes if it finds them.
There should be a global configuration option to turn this off instead of adding &noprocess one by one to each link.

This is an unintuitive anti-feature that breaks user expectations of being able to link to pages without unintended side-effects of breaking links by silently dropping commonly used attributes.
There have been several reports before from users unwittingly stumbling upon this, e.g. #989, #1877

@rhukster
Copy link
Member

Only a few reports in 5 years, disabling site-wide would mean huge chunks of functionality suddenly not working, leading to more issues/questions/etc. Might be better to put a good entry in the doc's so people find the solution quickly after googling.

@OleVik
Copy link
Contributor

OleVik commented May 24, 2020

This warrants a global option to disable though, as there are many cases where you either need the pass through of query parameters, or media-processing disabled altogether. It would be advantageous to be able to get the media with query-parameters and have Grav process it afterwards.

@otahirs
Copy link

otahirs commented Jun 1, 2020

I ran into the same issue.

@rhukster
Copy link
Member

rhukster commented Jun 4, 2020

Fixed via bfbe4ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants