Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding an empty meta field in Admin / Site unsets earlier metadata. #1972

Closed
ulab opened this issue Aug 9, 2019 · 4 comments
Closed

Adding an empty meta field in Admin / Site unsets earlier metadata. #1972

ulab opened this issue Aug 9, 2019 · 4 comments
Assignees
@w00fz @mahagr

Comments

@ulab
Copy link

ulab commented Aug 9, 2019

I have been trying to add an empty "generator" meta field to Admin / Site (as suggested), but this empties meta fields that are listed prior too.

I start with something basic like

Screenshot 2019-08-09 at 08 37 44

After saving the page, I empty the field for generator and save the page which results in

Screenshot 2019-08-09 at 08 38 06
@N-Parsons
Copy link

That is indeed a weird bug, and I can confirm that it's also present for me (Grav 1.6.11, Admin 1.9.7).

The workaround for disabling the generator meta tag is to set generator: 0 - the zero is interpreted as false.

@rhukster rhukster assigned rhukster and w00fz and unassigned rhukster Aug 9, 2019
@mahagr mahagr self-assigned this Jan 29, 2020
mahagr referenced this issue in getgrav/grav Jan 29, 2020
@mahagr
Fixed site.metadata saving issues [#2615]
6b887a9
@mahagr
Copy link
Member

mahagr commented Jan 29, 2020

I believe that the fixes I've made (blueprint saving + above one) fixes this issue.

@mahagr mahagr closed this as completed Feb 4, 2020
@NoNoNo
Copy link

NoNoNo commented Apr 10, 2020

@mahagr Still in version 1.7.0-rc.8!

@mahagr mahagr reopened this Apr 20, 2020
@w00fz w00fz transferred this issue from getgrav/grav Nov 17, 2020
w00fz added a commit that referenced this issue Nov 17, 2020
@w00fz
Better support for array field key/value when either key or value is …
ed8f24a 
…empty (fixes #1972)
@w00fz
Copy link
Member

w00fz commented Nov 17, 2020

This is now resolved in admin 1.10 develop.

Please note I have also transferred the ticket from grav to admin where it belongs.

@w00fz w00fz closed this as completed Nov 17, 2020
This was referenced Nov 17, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@w00fz w00fz

@mahagr mahagr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@w00fz @ulab @NoNoNo @mahagr @rhukster @N-Parsons