Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignetting filter for images #1364

Closed
olivierdalang opened this issue Mar 20, 2017 · 3 comments
Closed

Vignetting filter for images #1364

olivierdalang opened this issue Mar 20, 2017 · 3 comments
Labels

Comments

@olivierdalang
Copy link

Hi !

A very simple, nice and useful image filter is vignetting. Would it be possible to add it to grav ?
The implementation is very easy : http://php.net/manual/fr/function.imagefilter.php#109809

This would require to fork the gregwar library, but as far as I understand Grav doesn't rely on gregwar releases anyway.

I just tried the changes locally and it works great.

What do you think ?

@olivierdalang
Copy link
Author

See Gregwar/Image#137

@rhukster
Copy link
Member

We do still use Gregwar from composer. We were stuck on a specific commit, but i've now modified that to be just dev-master. If you can get your function added to Gregwar it will get picked up by Grav.

@olivierdalang
Copy link
Author

For the record, I made a PR here : Gregwar/Image#138
I hope it will get some attention as the repo doesn't seem very active...

I think if this gets merged, we'd still need to change system/src/Grav/Common/Page/Medium/ImageMedium.php to add vignette to $magic_actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants