Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it simpler to customize favicon #108

Open
eauchat opened this issue Apr 4, 2024 · 0 comments
Open

Make it simpler to customize favicon #108

eauchat opened this issue Apr 4, 2024 · 0 comments

Comments

@eauchat
Copy link

eauchat commented Apr 4, 2024

Thanks for the great theme.
Trying to customize the favicon I saw that it seem to be defined with:

 <link rel="icon" type="image/png" href="{{ url('theme://images/favicon.png') }}">

in the base template.
This makes it not trivial to customize the favicon. Practically the site admin needs to customize the theme, using inheritance.

Are you interested in adapting the code to make it simpler for site admins to use their own favicon. If yes, I can write a PR for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eauchat