Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Page from Page List drop-down menu does not seem to actually make a new page? #2139

Closed
paulhibbitts opened this issue May 3, 2021 · 6 comments
Assignees

Comments

@paulhibbitts
Copy link
Contributor

paulhibbitts commented May 3, 2021

Hello!

I noticed some comments about an updated page copy feature in Admin, so I tried out to Duplicate a page from the Admin Page List panel.

For some reason this does not result in a duplicate page, it looks like the the page underneath the purple "Copy created successfully" status message is in fact the source page vs. a new copy. Mac OX, Latest Firefox and Google Chrome.

Not sure if this is a new issue or existing, but thought I best share my test results.

Please let me know if any more info/details are helpful.

Thanks very much,
Paul

@mahagr
Copy link
Member

mahagr commented May 10, 2021

Looks like you're right -- the feature seems to only work when you are editing the page.

@mahagr
Copy link
Member

mahagr commented May 10, 2021

Make the copy to work without modal: getgrav/grav@d058c1d

@w00fz We still need to introduce the modal into the page list.

@w00fz
Copy link
Member

w00fz commented Jun 4, 2021

@mahagr We might need a new modal and logic for the pages list. Copying from the page edit is relying and expecting the form of the page itself to be submitted. For the listing we cannot do this, instead we need a whole new logic where all we have available for the task to receive are the URL/slug of the page + customizable settings such as new title/slug of the copy. We really cannot submit a form of a page it's not loaded yet.

Need you to start thinking about this, we can discuss it further in chat later.

@w00fz
Copy link
Member

w00fz commented Jun 4, 2021

I got this implemented. It is however a Flex Objects enhancement so it will be available at next Flex Objects release .

@w00fz w00fz unassigned mahagr Jun 4, 2021
@w00fz
Copy link
Member

w00fz commented Jun 7, 2021

This is now released in Flex Objects v1.0.14

@paulhibbitts
Copy link
Contributor Author

Awesome @w00fz , thanks so much! My MacBook Pro is getting repaired but once I get it back I'll try this out too🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants