Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set errors.display to -1, leaking full backtrace #1452

Closed
tribut opened this issue May 27, 2018 · 3 comments
Closed

Cannot set errors.display to -1, leaking full backtrace #1452

tribut opened this issue May 27, 2018 · 3 comments

Comments

@tribut
Copy link
Contributor

tribut commented May 27, 2018

When the admin interface is used to set the config setting error.display, it is impossible to set it to -1 (System error). The yaml file after saving looks like this:

errors:
  display: '-1'

Note that display is set to the string -1 due to the quotes. Grav later checks the setting using is_int and then discards the value.

This is an information disclosure security vulnerability, because Grav falls back to the full backtrace(!) when the user presumably wanted to make sure to leak as little information as possible.

@rhukster
Copy link
Member

What version of grav? This has never been an issue before. I will need to investigate why this is happening now.

@tribut
Copy link
Contributor Author

tribut commented May 29, 2018

Sorry for not mentioning versions: Grav v1.4.5 - Admin v1.8.2

@rhukster
Copy link
Member

Fixed here: getgrav/grav@636bc97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants