-
Notifications
You must be signed in to change notification settings - Fork 64
Block failing to render in editor #436
Comments
Thanks for bringing this up! Hi @BenHarris,
In my environment, it looks like it makes a GET request for the 'preview' display (ServerSideRender): Let me see if there's a way around this, though there probably won't be a quick fix. It uses ServerSideRender from Gutenberg. As you might have seen, there have been issues when a block has a lot of content, like in #254. |
Hey @kienstra,
Sorry, didn't see that issue. It is the same problem, only I found the root cause! |
Hi @BenHarris,
Thanks, where do you see that it's making a POST request? Locally, it looks like it's making a GET request, though I could be wrong: |
Ah, sorry. You're saying it should switch to use POST instead of GET. |
I'll see if that might help. It would involve reimplementing ServerSideRender, so I'm not sure about it. |
@lukecarbis pointed out that this Gutenberg issue is related: WordPress/gutenberg#16396 |
Closing in favour of WordPress/gutenberg#16396. |
Another user just reported this in Slack. We might look at forking ServerSideRender, and registering a POST endpoint for it, as suggested in WordPress/gutenberg#16396 (comment) |
Reopening since this is an active bug that isn't resolved. |
Yeah, this keeps coming up. As mentioned in WordPress/gutenberg#16396 (comment), one solution might be making a Core patch and a Gutenberg PR. But I don't think those are likely to be merged, as WordPress doesn't recommend We could fork ServerSideRender, and register a POST endpoint for it, as suggested in WordPress/gutenberg#16396 (comment). But then there would be 2 endpoints registered for each post, one through the This might have scaling issues, and would probably be overkill for most users. |
I don't know if it helps, but I do not have that issue with the 1.4.1 version of block lab. So I stick with that version beacause all of my blocks aren't displaying with version 1.5 and above. |
Hi @Foine, Hm, it's strange that the issue didn't appear in |
Hi @BenHarris, Sorry this has taken so long, and hope you're doing well. If you're still interested, could you please test a fix for the issue? Thanks, and have a great weekend. |
Hi @kienstra, No problem at all! Have just tested and it worked as expected 👍 great work! |
Thanks, @BenHarris! That helps a lot having you test it, glad that it works. It'll probably be in our next release. |
When attempting to render a block in the editor, the following error is displayed when the request size is greater than the web servers' limit (
LimitRequestLine
on Apache, defaulting to 8190):I hit the issue when building a team block with a repeater, where each of the 10 team members has some metadata and a bio.
It seems to me that the best solution would be to switch to using POST rather than GET.
The text was updated successfully, but these errors were encountered: