Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creator doesn't check against full asset name #445

Closed
davidlatwe opened this issue Sep 11, 2019 · 1 comment · Fixed by #446
Closed

Creator doesn't check against full asset name #445

davidlatwe opened this issue Sep 11, 2019 · 1 comment · Fixed by #446
Assignees
@davidlatwe
Labels
bug creator

Comments

@davidlatwe
Copy link
Collaborator

What happened?
When manually typing asset name into Creator's asset field, it will allow if any current existing asset names contains input text.

For example, if we have an asset called rock, these input will be valid: r, o, c, k, ro, ock..

What did you expect?
It should compare against full asset name.
@davidlatwe
Copy link
Collaborator Author

This is easy to fix, I'll submit a PR later.

@davidlatwe davidlatwe self-assigned this Sep 11, 2019
@davidlatwe davidlatwe mentioned this issue Sep 11, 2019
Merged
davidlatwe referenced this issue Sep 12, 2019
@davidlatwe
Merge pull request #446 from davidlatwe/Fix#445
141bb6d 
Fix#445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidlatwe davidlatwe

Labels
bug creator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix#445 davidlatwe/core
1 participant
@davidlatwe