Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update working node version #1589

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Conversation

vaibhavgarg237
Copy link
Contributor

@vaibhavgarg237 vaibhavgarg237 commented Oct 8, 2022

Describe the changes you have made in this PR

Updated working node version in Readme.md

Link this PR to an issue

Fixes #1588

Type of change

(Remove other not matching type)

  • docs: Documentation update

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

Copy link
Contributor Author

@vaibhavgarg237 vaibhavgarg237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below were the results on running unit tests locally for these node versions

v14.0.0 - FAILED
v14.1.0 - FAILED
v14.2.0 - FAILED
v14.4.0 - FAILED
v14.5.0 - FAILED

v14.6.0 - PASSED    
v14.7.0 - PASSED    
v14.17.0 - PASSED    
v14.15.0 - PASSED    
v14.20.1 - PASSED
v15.0.0 - PASSED
v15.14.0 - PASSED
v16.00.0 - PASSED

v16.17.1 - FAILED

@github-actions
Copy link

github-actions bot commented Oct 9, 2022

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

Don't forget: keep stacking sats!

@escapedcat escapedcat merged commit b357c06 into getAlby:master Oct 9, 2022
@vaibhavgarg237 vaibhavgarg237 deleted the fixDocs branch October 15, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants