Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mobile): dynamic theme #331

Merged
merged 1 commit into from
Sep 18, 2024
Merged

feat(mobile): dynamic theme #331

merged 1 commit into from
Sep 18, 2024

Conversation

bkdev98
Copy link
Member

@bkdev98 bkdev98 commented Sep 17, 2024 •
edited
Loading

Palette generated from https://ui.jln.dev/.

Todo:

  • Free user can not customize color palette.
  • UI test.
  • Added feature flag dynamic-color-palette.

@bkdev98 bkdev98 mentioned this pull request Sep 17, 2024
Merged
@bkdev98 Graphite App
Copy link
Member Author

bkdev98 commented Sep 17, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bkdev98 and the rest of your teammates on Graphite Graphite

This was referenced Sep 17, 2024
Merged
Merged
@bkdev98 bkdev98 added frontend enhancement New feature or request labels Sep 17, 2024 — with Graphite App
@bkdev98 bkdev98 marked this pull request as ready for review September 17, 2024 19:52
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 17, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (09/17/24)

1 reviewer was added to this PR based on Dustin Do's automation.

duongdev
duongdev reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@duongdev duongdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you implement feature flagging for this?

@bkdev98
Copy link
Member Author

bkdev98 commented Sep 18, 2024

Will you implement feature flagging for this?

in progress...

@bkdev98 bkdev98 force-pushed the 09-18-feat_mobile_dynamic_theme branch from bdb0a0c to dd22471 Compare September 18, 2024 16:32
@bkdev98
Copy link
Member Author

bkdev98 commented Sep 18, 2024

Screenshot 2024-09-18 at 23 33 13

@duongdev feature flag added!

@bkdev98 bkdev98 mentioned this pull request Sep 18, 2024
Merged
@duongdev Graphite App
Copy link
Member

Screenshot 2024-09-18 at 23 33 13

@duongdev feature flag added!

yay

@bkdev98 Graphite App
Copy link
Member Author

bkdev98 commented Sep 18, 2024 •
edited
Loading

Merge activity

  • Sep 18, 1:03 PM EDT: @bkdev98 started a stack merge that includes this pull request via Graphite.
  • Sep 18, 1:15 PM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 18, 1:19 PM EDT: Graphite couldn't merge this PR because it failed for an unknown reason.
  • Sep 18, 1:26 PM EDT: @bkdev98 started a stack merge that includes this pull request via Graphite.
  • Sep 18, 1:26 PM EDT: @bkdev98 merged this pull request with Graphite.

@bkdev98 bkdev98 changed the base branch from 09-18-feat_mobile_improve_category_select_sheet to graphite-base/331 September 18, 2024 17:11
@bkdev98 bkdev98 changed the base branch from graphite-base/331 to main September 18, 2024 17:13
@bkdev98 bkdev98 force-pushed the 09-18-feat_mobile_dynamic_theme branch from dd22471 to f1c2c02 Compare September 18, 2024 17:14
@bkdev98 bkdev98 merged commit 4d71436 into main Sep 18, 2024
5 checks passed
@bkdev98 bkdev98 deleted the 09-18-feat_mobile_dynamic_theme branch September 18, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duongdev duongdev duongdev approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request frontend
Projects
6pm
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkdev98 @duongdev