Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use single source for order matching fee #2341

Closed
holzeis opened this issue Mar 29, 2024 · 0 comments · Fixed by #2355
Closed

Use single source for order matching fee #2341

holzeis opened this issue Mar 29, 2024 · 0 comments · Fixed by #2355
Assignees
@bonomat
Labels
technical-debt

Comments

@holzeis
Copy link
Contributor

holzeis commented Mar 29, 2024

At the moment we use commons::order_matching_fee_taker to calculate the order matching fee on various places. This will become cumbersome once we want to work with fee discounts.

We should calculate the fees on only one place (order matching) and then pass it through to the end. (payout curve, trade, ..)
@holzeis holzeis changed the title Add single source for order matching fee Use single source for order matching fee Mar 29, 2024
@bonomat bonomat self-assigned this Apr 2, 2024
@bonomat bonomat mentioned this issue Apr 8, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bonomat bonomat

Labels
technical-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add referral feature get10101/10101
2 participants
@bonomat @holzeis