Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for local notifications #1045

Closed
klochowicz opened this issue Jul 31, 2023 Discussed in #953 · 12 comments · Fixed by #1091
Closed

Add support for local notifications #1045

klochowicz opened this issue Jul 31, 2023 Discussed in #953 · 12 comments · Fixed by #1091

Comments

@klochowicz
Copy link
Contributor

We should support sending push notifications based on local events.
One obvious situation where it can be plugged in is receiving a payment via LN.

Some point to get it started:

It would be great if it would be done in a way that coexists with #1044

@holzeis
Copy link
Contributor

holzeis commented Jul 31, 2023

One obvious situation where it can be plugged in is receiving a payment via LN.

Does that mean the local notifications look like native notifications?

@Restioson
Copy link
Contributor

Restioson commented Aug 2, 2023

Does that mean the local notifications look like native notifications?

I believe so, they would just originate from the app itself and not from a remote server a la push notifications.

PS: this package also exists https://pub.dev/packages/flutter_local_notifications

@holzeis
Copy link
Contributor

holzeis commented Aug 2, 2023

If that's the case, they are too generic in my opinion to show that a payment was received.

But maybe I feel differently when I've seen an example 🙂

@klochowicz
Copy link
Contributor Author

Does that mean the local notifications look like native notifications?

I believe so, they would just originate from the app itself and not from a remote server a la push notifications.

PS: this package also exists https://pub.dev/packages/flutter_local_notifications

🙃 this is literally the package in the link I've posted

@klochowicz
Copy link
Contributor Author

If that's the case, they are too generic in my opinion to show that a payment was received.

But maybe I feel differently when I've seen an example 🙂

This is how you have it in bank apps, isn't it?

@holzeis
Copy link
Contributor

holzeis commented Aug 2, 2023

Not in my bank app. But it's even worse there 🙈. You'll see a grey bar on the top that has a small white message that you can click. (If the app is open)

@Restioson
Copy link
Contributor

🙃 this is literally the package in the link I've posted

🙈

@Restioson
Copy link
Contributor

If that's the case, they are too generic in my opinion to show that a payment was received.

We can put any content in it, though, so in what sense would it be too generic?

@holzeis
Copy link
Contributor

holzeis commented Aug 2, 2023

If that's the case, they are too generic in my opinion to show that a payment was received.

We can put any content in it, though, so in what sense would it be too generic?

IMHO it's too generic in the context of a received payment. E.g. Breez is showing confetti, Zeus is showing a lightning and I think phoenix shows a dialog which depicts whether the payment for the created invoice was received.

@bonomat
Copy link
Contributor

bonomat commented Aug 3, 2023

I think with too generic @holzeis means it is not personalized for us, e.g. instead of a "boring" notification we could do a matrix animation which shows lots of 1s and 0s :D

@Restioson
Copy link
Contributor

IMHO it's too generic in the context of a received payment. E.g. Breez is showing confetti, Zeus is showing a lightning and I think phoenix shows a dialog which depicts whether the payment for the created invoice was received.

We could always expand on it inside the app itself, but it could be useful if the app is running in the background and the user receives the payment. The notification would then prompt them to re-open the app to see the fancy animations

@klochowicz
Copy link
Contributor Author

klochowicz commented Aug 3, 2023

Can we please move the discussion how they will look into #180 ?
this ticket is about local notifications feature, and there are many other use-cases for this. this was just an example.

@klochowicz klochowicz linked a pull request Aug 11, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants