Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files without file extension are not included for linting #338

Closed
tymonx opened this issue Jun 24, 2023 · 1 comment
Closed

Files without file extension are not included for linting #338

tymonx opened this issue Jun 24, 2023 · 1 comment

Comments

@tymonx
Copy link

tymonx commented Jun 24, 2023

Subject of the issue

Files without file extension are not included for linting. Example: README.

Your environment

  • OS: podman
  • Packages: podman run -it --rm registry.gitlab.com/pipeline-components/alex:0.21.9 --version
11.0.0
  • Env: podman run -it --rm registry.gitlab.com/pipeline-components/alex:0.21.9 env
NODE_VERSION=19.8.1
YARN_VERSION=1.22.19

Steps to reproduce

  1. Create file without file extension:
echo "pop" > README
  1. Run alex:
podman run -it --rm --volume "$(pwd):/alex:ro,z" --workdir "/alex" registry.gitlab.com/pipeline-components/alex:0.21.9 --why .

Expected behaviour

It should return status code 1 and print:

README
  1:1-1:4  warning  `pop` may be insensitive, use `parent` instead  dad-mom  retext-equality

⚠ 1 warning

Actual behaviour

It returns status code 0 (success) without printing anything to standard output or error output.

Workaround

Explicitly provide files without file extension to alex:

podman run -it --rm --volume "$(pwd):/alex:ro,z" --workdir "/alex" registry.gitlab.com/pipeline-components/alex:0.21.9 --why README

But this will not work when .alexignore is defined:

echo "README" > .alexignore

It returns status code 1 and prints:

README
  1:1  error  Cannot process specified file: it’s ignored

✖ 1 error

Related issues

@wooorm
Copy link
Member

wooorm commented Jun 25, 2023

Hi!

It is intentional that files without extensions, which could include any code, or be for example binary files, are not included by default.

If you want to include certain files, pass them: alex whatever

@wooorm wooorm closed this as not planned Won't fix, can't repro, duplicate, stale Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants