Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to sas7bdat.parso when haven fails #119

Closed
billdenney opened this issue Sep 8, 2016 · 2 comments
Closed

Fallback to sas7bdat.parso when haven fails #119

billdenney opened this issue Sep 8, 2016 · 2 comments
Labels

Comments

@billdenney
Copy link
Contributor

billdenney commented Sep 8, 2016

Would it be reasonable to fall back to the read.sas7bdat.parso library when reading sas7bdat files fails with haven? This library worked for me when other libraries (haven, sas7bdat) failed.

sas7bdat.parso is at https://github.com/BioStatMatt/sas7bdat.parso

FYI, this is related to BioStatMatt/sas7bdat#9 and tidyverse/haven#31, but the same file read without issue using read.sas7bdat.parso.

@leeper leeper added the question label Sep 8, 2016
@leeper
Copy link
Contributor

leeper commented Sep 8, 2016

I think probably not, but I'll consider it. The reasons for my initial reaction are that it (1) creates another dependency and (2) that dependency in particular relies on rJava, which is not exactly easy to get working reliably across platforms.

I'll take a look and see if it's possible to introduce changes in haven that will resolve that issue. Do those files fail under the development version of haven?

@billdenney
Copy link
Contributor Author

Ah! They do work with the development version of haven.

Thanks for the pointer to look there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants