Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sulfate_mod, Chem_H2O2 convert unit mistake #2302

Closed
Tracked by #2312
CraigYEUNG opened this issue May 22, 2024 · 2 comments · Fixed by #2413
Closed
Tracked by #2312

Sulfate_mod, Chem_H2O2 convert unit mistake #2302

CraigYEUNG opened this issue May 22, 2024 · 2 comments · Fixed by #2413
Assignees
Labels
category: Bug Something isn't working never stale Never label this issue as stale topic: Aerosol-Only Simulation Related to the GEOS-Chem Aerosol-Only simulation
Milestone

Comments

@CraigYEUNG
Copy link

CraigYEUNG commented May 22, 2024

While using GC14.3.0 Aerosol-only simulation, sulfate_mod.F90 use Chem_H2O2 by:

       DH2O2 = ( PH2O2m(I,J,L) / TS_EMIS * XNUMOL_H2O2 / CM3PERM3 ) &
               * DT / ( ALPHA * M )
       H2O2  = ( H2O20 / ALPHA + DH2O2 )

this is to convert unit of kg/m3 to molec/cm3/s

But I found that in dryrun downloaded Prodloss file, Prod_H2O2 unit is already molec/cm3/s. Thus, if still use XNUMOL_H2O2 / CM3PERM3, H2O2 concentration will be much higher.

@yantosca yantosca self-assigned this May 22, 2024
@yantosca yantosca added category: Bug Something isn't working topic: Aerosol-Only Simulation Related to the GEOS-Chem Aerosol-Only simulation labels May 22, 2024
@yantosca
Copy link
Contributor

yantosca commented May 23, 2024

Thanks for writing @CraigYEUNG. This issue may have crept in during implementation of the KPP chemistry mechanism in the full-chemistry simulation (in v11-01). All of the prod/loss outputs are in molec/cm3/s as they are generated by KPP.

We can implement a fix for this in a future bugfix version. For now, you can remove the XNUMOL_H2O2 / CMPERM3 in your code. Thanks for alerting us to this!

We only benchmark the full-chemistry simulation, so we wouldn't have caught this. We look to users like you to provide us with bug reports for aerosol-only and other specialty simulations.

@yantosca yantosca added the never stale Never label this issue as stale label May 30, 2024
@yantosca yantosca added this to the 14.4.1 milestone Jun 7, 2024
@yantosca yantosca removed this from the 14.4.1 milestone Jun 28, 2024
@yantosca yantosca added this to the 14.4.3 milestone Aug 6, 2024
@yantosca
Copy link
Contributor

We can now close this issue as PR #2413 is now merged into 14.4.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Something isn't working never stale Never label this issue as stale topic: Aerosol-Only Simulation Related to the GEOS-Chem Aerosol-Only simulation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants