Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Consider activating additional diagnostics in benchmark simulations #2149

Closed
msulprizio opened this issue Feb 7, 2024 · 1 comment · Fixed by #2399
Closed
Assignees
Labels
category: Feature Request New feature or request topic: Benchmarking and Testing Related to CI, integration tests, or scientific benchmarking
Milestone

Comments

@msulprizio
Copy link
Contributor

Name and Institution (Required)

Name: Melissa Sulprizio
Institution: Harvard / GCST

New GEOS-Chem feature or discussion

Benchmark run directories are currently created with the following diagnostic collections enabled in HISTORY.rc:

COLLECTIONS: 'Restart',
             'Metrics',
             'SpeciesConc',
             'AdvFluxVert',
             'AerosolMass',
             'Aerosols',
             #'Budget',
             #'CloudConvFlux',
             #'ConcAboveSfc',
             #'ConcAfterChem',
             #'DryDep',
             'JValues',
             #'KppDiags',
             #'KppARDiags',
             #'LevelEdgeDiags',
             #'ProdLoss',
             #'RRTMG',
             #'RxnRates',
             #'RxnConst',
             #'SatDiagn',
             #'SatDiagnEdge',
             #'StateChm',
             'StateMet',
             #'StratBM',
             #'Tomas',
             #'UVFlux',
             #'WetLossConv',
             #'WetLossLS',
             #'BoundaryConditions',             

However, for 1-year benchmarks, we need to activate (uncomment) additional diagnostic collections, including:

  • DryDep
  • ProdLoss
  • WetLossConv
  • WetLossLS
  • LevelEdgeDiags
  • ConcAfterChem
  • StateChm
  • CloudConvFlux

To detect issues and/or changes in these diagnostics earlier, we should include them in 1-hr and 1-month benchmarks. To avoid saving out large files we could consider saving out a subset of specie/diagnostics in each collection.

@msulprizio msulprizio added category: Feature Request New feature or request topic: Benchmarking and Testing Related to CI, integration tests, or scientific benchmarking labels Feb 7, 2024
@msulprizio msulprizio self-assigned this Mar 20, 2024
@yantosca yantosca added this to the 14.4.3 milestone Jul 30, 2024
@yantosca yantosca linked a pull request Jul 30, 2024 that will close this issue
3 tasks
@yantosca
Copy link
Contributor

We can now close this issue as "alldiags" integration test were introduced in PR #2399.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request topic: Benchmarking and Testing Related to CI, integration tests, or scientific benchmarking
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants