Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate all diagnostics in at least one of the GEOS-Chem integration tests #2143

Closed
1 task done
yantosca opened this issue Feb 2, 2024 · 1 comment · Fixed by #2399
Closed
1 task done

Activate all diagnostics in at least one of the GEOS-Chem integration tests #2143

yantosca opened this issue Feb 2, 2024 · 1 comment · Fixed by #2399
Assignees
@yantosca
Labels
category: Feature Request New feature or request no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: Benchmarking and Testing Related to CI, integration tests, or scientific benchmarking

Comments

@yantosca
Copy link
Contributor

yantosca commented Feb 2, 2024

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Confirm you have reviewed the following documentation

New GEOS-Chem feature or discussion

In previous discussion (see #2135, #2139, #2142), it was discovered that incorrect species lists in the HISTORY.rc file (particularly for GCHP, which does not use wildcards) can cause diagnostics to fail. It would be prudent to activate all diagnostics in one of the GEOS-Chem integration tests (perhaps for the fullchem_benchmark) to check if there are any such issues.

Tagging @msulprizio @lizziel
@yantosca yantosca added category: Feature Request New feature or request topic: Benchmarking and Testing Related to CI, integration tests, or scientific benchmarking no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations labels Feb 2, 2024
@yantosca yantosca self-assigned this Feb 2, 2024
@yantosca yantosca mentioned this issue Feb 2, 2024
Closed
@yantosca yantosca mentioned this issue Jun 7, 2024
Open
9 tasks
@msulprizio msulprizio mentioned this issue Jul 24, 2024
Merged
3 tasks
@msulprizio msulprizio linked a pull request Jul 24, 2024 that will close this issue
Add simulation with all diagnostics turned to integration testing #2399
Merged
3 tasks
@yantosca
Copy link
Contributor Author

yantosca commented Oct 8, 2024

We can close out this issue as PR #2399 is now merged.

@yantosca yantosca closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yantosca yantosca

Labels
category: Feature Request New feature or request no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: Benchmarking and Testing Related to CI, integration tests, or scientific benchmarking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add simulation with all diagnostics turned to integration testing geoschem/geos-chem
1 participant
@yantosca