Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support for recipeInstruction as string; added step formating #503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added support for recipeInstruction as string; added step formating #503

wants to merge 1 commit into from

Conversation

JohannesFleischer
Copy link

@JohannesFleischer JohannesFleischer commented Oct 24, 2024 •
edited
Loading

This MR adds scraping support for websites which store the recipeInstructions as a string and not as an array of objects.

This includes chefkoch.de and therefore closes #278 and #498

Also included is a minor additional formatting of the Steps including paragraphs and numbering:

image

@iwontknow
Copy link

Is there someone who is able to check the merge request and merge it?
I cant add recipes because, i get this error everywhere i try to get a recipe.

@JohannesFleischer
Copy link
Author

@iwontknow you could verify/test if my changes fix your problem or tell me which site you want to scrape from, and then I could take a look when I have some time.

@iwontknow
Copy link

iwontknow commented Nov 28, 2024 •
edited
Loading

@iwontknow you could verify/test if my changes fix your problem or tell me which site you want to scrape from, and then I could take a look when I have some time.

I will try it tomorrow and report back.

Edit - 2024-11-29:
I have tested it on 2 different sites that were not working before and so far they are working after this commit.

sites:
chefkoch.de, ndr.de/ratgeber/kochen/rezepte/

@JohannesFleischer Can you check out why https://www.lidl-kochen.de/rezeptwelt/klassischer-gurkensalat-150209 for example isnt working? It just shows: "Unable to extract Recipe metadata from provided url"

@iwontknow iwontknow mentioned this pull request Nov 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when importing from chefkoch.de
2 participants
@JohannesFleischer @iwontknow