Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question/Compatibility] Why are chemical sprayer projectiles never on fire #95

Open
darklordwonton opened this issue Apr 24, 2024 · 0 comments

Comments

@darklordwonton
Copy link

darklordwonton commented Apr 24, 2024

I was trying to figure out why the chemical sprayer wasn't working with dynamic lighting since I assumed that the projectiles that are fired when you light gasoline were on fire, which makes vanilla flaming arrows and on-fire projectiles from other mods glow. I looked into the code and noticed that while it looks like those projectiles are given the Fire tag there's an overload for isOnFire that makes it always return false (https://github.com/george8188625/Create-Diesel-Generators/blob/1.19.2/src/main/java/com/jesz/createdieselgenerators/entity/ChemicalSprayerProjectileEntity.java#L188). I assume there's probably a good reason for that, I'm just curious as to what that reason is.

I guess this is also a bug report/feature request that flaming chemical sprayer projectiles don't work with dynamic lighting mods. Not a major issue but it would look pretty cool if it was compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant