Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method VersionUpdate::canSkip should be named "VersionUpdate::canApply" #49

Closed
bmarwell opened this issue Jul 18, 2022 · 1 comment · Fixed by #44
Closed

Method VersionUpdate::canSkip should be named "VersionUpdate::canApply" #49

bmarwell opened this issue Jul 18, 2022 · 1 comment · Fixed by #44

Comments

@bmarwell
Copy link
Contributor

Method is used contrary to naming:

 UpdateResolver(
                    mavenProject = mavenProject,
                    artifactMetadataSource = artifactMetadataSource,
                    localRepository = localRepository,
                    artifactFactory = artifactFactory
            )
            .updates
            .onEach { println("execute im mojo: latestVersion: '${it.latestVersion}' / version:'${it.version}'") }
            .filter(VersionUpdate::canSkip)
@sparsick
Copy link
Collaborator

sparsick commented Jul 19, 2022

Thank you. Yes, we also recognize it. We will change it with #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants