-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination components refactoring #1062
base: main
Are you sure you want to change the base?
Conversation
Affected libs:
|
📷 Screenshots are here! |
Better reaction to change, style matches mockup
eb23d36
to
a42729d
Compare
GitHub Pages links:
|
Thanks @jahow , the pagination works as expected!! |
Description
This PR is a refactoring aimed at simplifying and homogenizing pagination across the project:
Paginable
interface is introduced; any component that can handle pagination, be it async or sync, should implement this APIui/layout
module, there's 4 of them (prev/next buttons, pagination dots, page numbers from the Editor and page selector from the organizations page in the Datahub)Architectural changes
Moved several components from ui/elements to ui/layout
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label