Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel of a WGS84 lat/lon inside a certain Tile #18

Open
5fcgdaeb opened this issue Oct 29, 2020 · 2 comments
Open

Pixel of a WGS84 lat/lon inside a certain Tile #18

5fcgdaeb opened this issue Oct 29, 2020 · 2 comments

Comments

@5fcgdaeb
Copy link

5fcgdaeb commented Oct 29, 2020

This is a great library, thanks for putting it together.

One useful enhancement would be to calculate the pixel of a latitude/longitude inside a given Tile. Adding this capability to the Tile class would probably make sense, something along the lines of:

# Calculates the pixel location of a point inside the tile
def pixels(self, of_point: Point) -> (int, int): 
   pass

I can do this as well but let's discuss if this feature makes sense for the library.

Thanks!

@Murthy10
Copy link
Collaborator

Murthy10 commented Nov 2, 2020

Hi @5fcgdaeb

Sounds like a reasonable extension.
Can you provide a pull request for that?

Further, to don't get confused with the pixels of a point (Pixel Pyramid) maybe we should think about a more suited method name.

@5fcgdaeb
Copy link
Author

5fcgdaeb commented Nov 3, 2020

Sure, will get that going in the next few days!

I see what you mean with the Pixel Pyramid. Will try to come up with a more descriptive name there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants