-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CMake support #536
add CMake support #536
Conversation
Oh, I am glad I didnt make the PR ;-). Did you see #281? I am not sure what we can use from there, but it is worth checking. I am happy to test this branch on my system. |
Thanks for pointing that out. I've checked and I think the new CMake is already more advanced. In particular the handling of |
As a bonus we get support for the new LLVM-based Intel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The system already works well for me. Some small suggestions for the CMakeLists
.
It even works fine on Cray systems with the cray-fftw. The main thing I still want to try is pleiades. |
I tested the build on the NSF/TACC systems Stampede3 and Frontera, both use Intel compilers and MKL. I used Intel icc 19.1 on Frontera, and Intel 2024 (the new clang based) on Stampede3. Both worked fine, except I needed to load the fftw3 module. |
80e1f71
to
1d1ecae
Compare
I think this is ready now. When I added the test, I got an error with the macOS tester because it passed |
4680f45
to
8bfcd35
Compare
This prevents cmake from accidentally picking up the src/build directory from a previous configure based build.
Co-authored-by: Philipp Edelmann <[email protected]>
That makes the cmake tester work on macos.
@feathern We have a changelog entry now. Feel free to merge it at any time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- approved.
This adds support for building Rayleigh using CMake. It is purely optional and does not interfere with the traditional,
configure
-based approach.You can try it like this:
The
rayleigh
executable will be placed inbuild/src
.Todo:
Run_Param_Header.F
. The Fortran flags are currently missing. The linker flags have aSHELL:
prefix.Debug
andRelease
builds.bin
.