Safeguard equation_coefficients file to reflect the actual code #447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds a new subroutine,
Set_Reference_Equation_Coefficients()
to the PDE_Coefficients module, which is called at the end of the Initialize_Reference() subroutine. The subroutine sets ra_constants and ra_functions (except ones having to do with diffusion, heating, and buoyancy) directly from the "ref" object and is independent of reference_type. This reduces code bloat (previously there were several repeated lines at the end of each ...Reference() subroutine specifying ra_constants/ra_functions in the exact same way), should ensure that the equation_coefficients file always reflects the equations the code actually solved, and should make future reference_type's less error-prone.
This pull request is the natural follow on to #443, which safeguarded the ra_constants/ra_functions having to do with the diffusions.