-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chapter 15 -- internal review #786
Comments
Yes, it is 😊 |
Hi @jannes-m, I read the whole chapter, made some minor changes (#793), and also have some questions/comments for you:
|
Also -- please recheck the exercises in this chapter -- I cannot reproduce some of them. |
Hey @Nowosad, |
Hi @jannes-m -- no problem. Family is always a priority. |
Hi @jannes-m are you able to work on this? My current thinking is that the issues raised by @Nowosad above are sufficiently minor that they can be fixed during or after the review process. I'm looking at the issues related to submitting the 3rd part for peer review and this seems the biggest 'blocker', that does not actually need to be a blocker. https://github.com/Robinlovelace/geocompr/milestone/10 |
Will work on this the coming week. |
This is indeed the case, but we are only saying the algorithm should try for 500 times if necessary to reach a solution. If it can come up with an optimal solution without having to use 500 trials, all the better. It also says so in the text. |
Good catch, thanks a ton! It would be awesome if it also solved the 15-eco-16 code chunk problem! Taken care of via #ee19a40c
I have added following two sentences:
Changed as requested.
I have added the corresponding reference: [@probst_hyperparameters_2018]
I have replaced it with the new link. |
One of the problems was in fact that |
Hi @jannes-m one small suggestion; can you add small comments to some packages used in this chapter, e.g., |
Just fyi @Nowosad,I have added the short package descriptions. |
Hi @jannes-m where? I cannot find it in the book... Is it in some branch? |
branch ecology_finetuning |
Hi @jannes-m -- is the Ecology chapter ready for our internal review?
The text was updated successfully, but these errors were encountered: