Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Rust CI a bit #697

Closed
gadomski opened this issue Aug 13, 2024 · 2 comments · Fixed by #699
Closed

Refactor Rust CI a bit #697

gadomski opened this issue Aug 13, 2024 · 2 comments · Fixed by #699

Comments

@gadomski
Copy link
Contributor

With #696, the tests take a lot longer to run since there's more doc tests. We can probably break up the checks in Lint and Test to not run the entire test suite twice, sequentially.

@gadomski can take this on after #696 lands.

@kylebarron
Copy link
Member

I remember reading somewhere that doc tests are really slow because each is compiled as its own binary.

References:

@gadomski
Copy link
Contributor Author

I remember reading somewhere that doc tests are really slow because each is compiled as its own binary.

Yup, it's a bit of a tradeoff, but I still like having them generally because it's such a good way to ensure your docs Actually Work™.

We'll save a lot by not running tests twice here:

cargo test --all
cargo test --all --all-features

There may be some other sensible split-into-separate-jobs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants