-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger deploy workflow of geneontology.github.io
when gorefs.yaml
changes
#2235
Comments
@pgaudet @suzialeksander When we reach this point, it would be good to review the changes (minimal to none at your end) and think about how (if?) to link this from the main geneontology.org pages. |
It may be a good idea to deploy these on the GO website, unless the layout we have improves; right now it's a bit weird to send users to the GH markdown page (for eg https://github.com/geneontology/go-site/blob/master/metadata/gorefs/goref-0000001.md) - if I were a user I would not be sure whether I landed there on purpose. |
@pgaudet To clarify, having these built in to the main site is the point of those section. I'm trying to specify how you want to specifically present it. |
You comment " think about how (if?) to link this from the main geneontology.org pages." sounded like we were considering moving the GOREFs to the website, not that it was decided. Thanks for the clarification. |
Yes, just reiterating that the plan is to deprecate and remove the Markdown files. There will be pages instead of geneontology.org. The format of those pages isn't fully specified. As part of geneontology/geneontology.github.io#506 I imagine I will make a prototype of those pages and get feedback before finalizing it. |
This is now done with #2294 and related PRs. As an example, the merge of this PR into |
To be done after geneontology/geneontology.github.io#507
metadata/gorefs.yaml
in themaster
branch. The workflow should use the GitHub CLI to trigger the build and deploy workflow (created as part of Pull latestgorefs.yaml
file before building and deploying to GitHub Pages geneontology.github.io#507) in thegeneontology.github.io
repo (something along the lines ofgh workflow run -R ...
). We'll need a repo administrator to add a GitHub token with permission to run that workflow as a secret in this repo. We'll also need to take care to coordinate this with the QC workflow and ensure that this workflow only runs if QC succeeded.The text was updated successfully, but these errors were encountered: