Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger deploy workflow of geneontology.github.io when gorefs.yaml changes #2235

Closed
1 task
pkalita-lbl opened this issue Feb 14, 2024 · 6 comments
Closed
1 task
Assignees

Comments

@pkalita-lbl
Copy link
Contributor

To be done after geneontology/geneontology.github.io#507

  • Add a new workflow to this repo which is triggered on changes to metadata/gorefs.yaml in the master branch. The workflow should use the GitHub CLI to trigger the build and deploy workflow (created as part of Pull latest gorefs.yaml file before building and deploying to GitHub Pages geneontology.github.io#507) in the geneontology.github.io repo (something along the lines of gh workflow run -R ...). We'll need a repo administrator to add a GitHub token with permission to run that workflow as a secret in this repo. We'll also need to take care to coordinate this with the QC workflow and ensure that this workflow only runs if QC succeeded.
@kltm
Copy link
Member

kltm commented Feb 15, 2024

@pgaudet @suzialeksander When we reach this point, it would be good to review the changes (minimal to none at your end) and think about how (if?) to link this from the main geneontology.org pages.

@pgaudet
Copy link
Contributor

pgaudet commented Feb 15, 2024

It may be a good idea to deploy these on the GO website, unless the layout we have improves; right now it's a bit weird to send users to the GH markdown page (for eg https://github.com/geneontology/go-site/blob/master/metadata/gorefs/goref-0000001.md) - if I were a user I would not be sure whether I landed there on purpose.

@kltm
Copy link
Member

kltm commented Feb 15, 2024

@pgaudet To clarify, having these built in to the main site is the point of those section. I'm trying to specify how you want to specifically present it.

@pgaudet
Copy link
Contributor

pgaudet commented Feb 15, 2024

You comment " think about how (if?) to link this from the main geneontology.org pages."

sounded like we were considering moving the GOREFs to the website, not that it was decided. Thanks for the clarification.

@pkalita-lbl
Copy link
Contributor Author

Yes, just reiterating that the plan is to deprecate and remove the Markdown files. There will be pages instead of geneontology.org. The format of those pages isn't fully specified. As part of geneontology/geneontology.github.io#506 I imagine I will make a prototype of those pages and get feedback before finalizing it.

@pkalita-lbl
Copy link
Contributor Author

This is now done with #2294 and related PRs.

As an example, the merge of this PR into master trigger this workflow run: https://github.com/geneontology/go-site/actions/runs/8669326165. That workflow run in turn triggered this workflow run in the geneontology.github.io repo: https://github.com/geneontology/geneontology.github.io/actions/runs/8669329419.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants