Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic schema checker to validate gorefs.yaml #1805

Closed
2 tasks
Tracked by #1764
sujaypatil96 opened this issue Feb 25, 2022 · 2 comments
Closed
2 tasks
Tracked by #1764

Add automatic schema checker to validate gorefs.yaml #1805

sujaypatil96 opened this issue Feb 25, 2022 · 2 comments
Assignees

Comments

@sujaypatil96
Copy link
Contributor

sujaypatil96 commented Feb 25, 2022

After completing both issue #1803 and #1804, we need to add a schema checker, which should be a JSON Schema file that validates any future modifications made to the gorefs.yaml file in a Github Action step.

We can break out the tasks for this issue into two steps:

  • Create JSON Schema file that appropriately describes the structure of the data that should be present in the gorefs.yaml file
  • Add jsonschema CLI validate command to Github Actions so it verifies the correctness of file after every modification to it
@sujaypatil96 sujaypatil96 self-assigned this Feb 25, 2022
@sujaypatil96 sujaypatil96 changed the title add automatic schema checker Add automatic schema checker to validate gorefs.yaml Feb 25, 2022
@kltm
Copy link
Member

kltm commented Feb 26, 2022

To fit with the current naming conventions, unless there is other mechanism needed or reason otherwise, /metadata/gorefs.schema.yaml would be fine here.

@kltm kltm assigned pkalita-lbl and unassigned sujaypatil96 Feb 10, 2024
@kltm
Copy link
Member

kltm commented Feb 15, 2024

Closing out in preference for new worklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants