-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for obsolete/merged external ontology IDs #14605
Comments
Related (possibly duplicate) #13793 |
@dougli1sqrd is investigating why this didn't appear in the travis report |
So robot is not doing the imports closure during a sparql query it looks like. This would explain why we get no results. On rdf.geneontology.org, I ran a query to find violations (keeping in mind the data there is a little old at this point) and these are the results I found attached. Go to the following link to see and try the query I used to get these results: http://yasgui.org/short/BJu_bqN-M If robot is supposed to do the imports closure, but isn't we should fix that. Hope this helps. |
You cab run merge first
…On Dec 5, 2017 17:01, "dougli1sqrd" ***@***.***> wrote:
So robot is not doing the imports closure during a sparql query it looks
like. This would explain why we get no results. On rdf.geneontology.org,
I ran a query to find violations (keeping in mind the data there is a
little old at this point) and these are the results I found attached
<https://github.com/geneontology/go-ontology/files/1533494/classes_linking_to_deprecated_terms.csv.txt>
.
Go to the following link to see and try the query I used to get these
results: http://yasgui.org/short/BJu_bqN-M
If robot is supposed to do the imports closure, but isn't we should fix
that. Hope this helps.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#14605 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADGOUSFG7BIfMqpEZUBEadVlTvss2Uwks5s9ed2gaJpZM4Qle0X>
.
|
To add to import file:
@cmungall Thanks, Pascale
|
fixed obsolete chebi alkanesulfonate oxoanion for #14605
#14769 Should help. |
@cmungall @dougli1sqrd |
No not yet. @cmungall still has to tell us how to fix GOCHE (unless I missed a meeting or something). My PR won't pass until we fix GOCHE (also fixing this issue), and then once my PR is in, we'll in the future detect more obsolete references like this. |
@dougli1sqrd Chris will help you :) |
…main makefile See #14605 Fixes cmungall/bio-chebi#1
@dougli1sqrd I moved the substance by role building to the main go-ontology Makefile and rebuilt chebi_import - does it look OK now? |
Apparently not? I'm not totally sure what happened, but there seem to be more obsolete references? https://travis-ci.org/geneontology/go-ontology/builds/340666568?utm_source=github_status&utm_medium=notification |
We next need to run That will fix at least some, at least the first one, where GO references GOCHE_26619
robot repair should be able to migrate the GO axiom to GOCHE_25212 based on the info above This case is due to the fact that CHEBI obsoleted their original metabolite, see http://www.ebi.ac.uk/chebi/searchId.do?chebiId=26619 Aside: it's not clear why CHEBI did this, it creates churn for us, and it seems https://www.ebi.ac.uk/ols/ontologies/chebi/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FCHEBI_25212 was only created recently, grumble.. |
Hello,
Can we add a rule to flag or replace obsolete classes from external ontologies ? For eg in
GO:0019694 alkanesulfonate metabolic process
we have a link to CHEBI:22318 in the equivalence axiom, which now a secondary ID of CHEBI:134249.
@cmungall what is our process for dealing with these changes?
Thanks, Pascale
The text was updated successfully, but these errors were encountered: