Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for obsolete/merged external ontology IDs #14605

Closed
pgaudet opened this issue Nov 21, 2017 · 13 comments
Closed

Check for obsolete/merged external ontology IDs #14605

pgaudet opened this issue Nov 21, 2017 · 13 comments
Assignees

Comments

@pgaudet
Copy link
Contributor

pgaudet commented Nov 21, 2017

Hello,

Can we add a rule to flag or replace obsolete classes from external ontologies ? For eg in
GO:0019694 alkanesulfonate metabolic process
we have a link to CHEBI:22318 in the equivalence axiom, which now a secondary ID of CHEBI:134249.

@cmungall what is our process for dealing with these changes?

image

Thanks, Pascale

@tberardini
Copy link
Contributor

Related (possibly duplicate) #13793

@cmungall
Copy link
Member

cmungall commented Dec 5, 2017

@dougli1sqrd is investigating why this didn't appear in the travis report

@dougli1sqrd
Copy link
Contributor

So robot is not doing the imports closure during a sparql query it looks like. This would explain why we get no results. On rdf.geneontology.org, I ran a query to find violations (keeping in mind the data there is a little old at this point) and these are the results I found attached.

Go to the following link to see and try the query I used to get these results: http://yasgui.org/short/BJu_bqN-M

If robot is supposed to do the imports closure, but isn't we should fix that. Hope this helps.

@cmungall
Copy link
Member

cmungall commented Dec 6, 2017 via email

@pgaudet
Copy link
Contributor Author

pgaudet commented Dec 6, 2017

To add to import file:
CHEBI:28297 hydantoin-5-propionic acid
CHEBI:69404 pestalamide A
ChEBI ID | CHEBI:69403 carbonarone A
CHEBI:77506 1-pentadecene

@cmungall
How do I run the 'make file'?

Thanks, Pascale

 

pgaudet added a commit that referenced this issue Dec 6, 2017
fixed obsolete chebi alkanesulfonate oxoanion for #14605
@dougli1sqrd
Copy link
Contributor

#14769 Should help.

@pgaudet
Copy link
Contributor Author

pgaudet commented Jan 30, 2018

@cmungall @dougli1sqrd
Can this be closed ?

@dougli1sqrd
Copy link
Contributor

dougli1sqrd commented Jan 30, 2018

No not yet. @cmungall still has to tell us how to fix GOCHE (unless I missed a meeting or something). My PR won't pass until we fix GOCHE (also fixing this issue), and then once my PR is in, we'll in the future detect more obsolete references like this.

@pgaudet
Copy link
Contributor Author

pgaudet commented Feb 7, 2018

@dougli1sqrd Chris will help you :)

@cmungall
Copy link
Member

@dougli1sqrd I moved the substance by role building to the main go-ontology Makefile and rebuilt chebi_import - does it look OK now?

@dougli1sqrd
Copy link
Contributor

Apparently not? I'm not totally sure what happened, but there seem to be more obsolete references? https://travis-ci.org/geneontology/go-ontology/builds/340666568?utm_source=github_status&utm_medium=notification

@cmungall
Copy link
Member

We next need to run robot repair. @pgaudet is that something we should do a quick 10 min intro to the ontology group for.

That will fix at least some, at least the first one, where GO references GOCHE_26619

   <owl:Class rdf:about="http://purl.obolibrary.org/obo/GOCHE_26619">
        <obo:IAO_0100001 rdf:resource="http://purl.obolibrary.org/obo/GOCHE_25212"/>
        <owl:deprecated rdf:datatype="http://www.w3.org/2001/XMLSchema#boolean">true</owl:deprecated>
    </owl:Class>

robot repair should be able to migrate the GO axiom to GOCHE_25212 based on the info above

This case is due to the fact that CHEBI obsoleted their original metabolite, see http://www.ebi.ac.uk/chebi/searchId.do?chebiId=26619

Aside: it's not clear why CHEBI did this, it creates churn for us, and it seems https://www.ebi.ac.uk/ols/ontologies/chebi/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FCHEBI_25212 was only created recently, grumble..

@dougli1sqrd
Copy link
Contributor

#14769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants