Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change activationEvents to stop eager/unnecessary load #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

willstocks
Copy link

Adjustment to the activationEvents from * to specifically looking for scss or sass

Adjustment to the `activationEvents` from `*` to specifically looking for `scss` or `sass`
@gencer
Copy link
Owner

gencer commented Aug 10, 2021

Hey @willstocks!

Thanks for the PR.

Sounds great. But I think we should extend this more. See, SCSS Everywhere is different than other extension which is not only autocompletes and do caches on SCSS/CSS but also on *.slim,*.ts,*.js,*.erb..... I am wondering how will this affect those files. Because, If I get it right, user first needs to open a CSS/SCSS File first to get this extension work.

@willstocks
Copy link
Author

Hey @gencer
No worries! 😄
I included "workspaceContains:**/*.s[ac]ss", so that it activates as long as the workspace contains one of these file types (I'll adjust to include vanilla .css as well), but it will also activate on just .scss or .sass files being opened (again, I can adjust this to look for vanilla .css as well if you'd like?).
That being said, you make a very good point and I will get the file-types updated so that it includes all of the following: css, scss, sass, eex, slim, ts(x), js(x), haml, svelte, liquid, tpl, latte, php, html, twig, erb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants