Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #740 #741

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Fix #740 #741

merged 2 commits into from
Jan 9, 2023

Conversation

AlexanderJuestel
Copy link
Contributor

Description

Replacing parse_color() with pv.Color().float_rgb

Relates to #740

Checklist

  • My code follows the PEP 8 style guidelines.
  • My code uses type hinting for function and method arguments and return values.
  • My code contains descriptive and helpful docstrings
    which are formatted per the Google Python Style Guidelines.
  • I have created tests which entirely cover my code.
  • The test code either 1. demonstrates at least one valuable use case (e.g. integration tests)
    or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).
  • New and existing tests pass locally with my changes.

@AlexanderJuestel
Copy link
Contributor Author

Failures of checks are unrelated to this PR but should be addressed as well

@Japhiolite Japhiolite merged commit 1b2d29b into master Jan 9, 2023
@AlexanderJuestel AlexanderJuestel deleted the fix_parse_color branch May 26, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants