Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export to vtk #649

Merged

Conversation

mkondratyev85
Copy link
Contributor

Description

A small change that solves issue #641 that was causing a bug while exporting a model to vtk via Pyvista.
The Pyvista receives a flatten array but the gempy passed 3D array of lithology to set values to mesh cells.

As only a single line was changed I don't know if I have to check boxes in the checklists below, so I leave them unchecked for now.

Checklist

  • My code follows the PEP 8 style guidelines.
  • My code uses type hinting for function and method arguments and return values.
  • My code contains descriptive and helpful docstrings
    which are formatted per the Google Python Style Guidelines.
  • I have created tests which entirely cover my code.
  • The test code either 1. demonstrates at least one valuable use case (e.g. integration tests)
    or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).
  • New and existing tests pass locally with my changes.

@AlexanderJuestel
Copy link
Contributor

@mkondratyev85 thanks for opening the PR, I still have to reproduce the issue in the first place. If your fix works, which I am sure it does, I would merge it to my dev branch where I am working on #640. Would that be okay?

@AlexanderJuestel
Copy link
Contributor

I can confirm that the proposed change will fix issue #641

@AlexanderJuestel AlexanderJuestel changed the base branch from master to dev_alexj October 29, 2021 06:09
@AlexanderJuestel AlexanderJuestel merged commit 2378578 into gempy-project:dev_alexj Oct 29, 2021
@mkondratyev85
Copy link
Contributor Author

Hi @AlexanderJuestel! Thank you so much for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants