Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't handle null SED #435

Open
tpolecat opened this issue Feb 23, 2023 · 3 comments
Open

can't handle null SED #435

tpolecat opened this issue Feb 23, 2023 · 3 comments

Comments

@tpolecat
Copy link
Member

@cquiroz is getting Error parsing point profile when setting the sed to null so I think this needs to handle that case:

@tpolecat
Copy link
Member Author

Or if the ITC can't do anything with the null sed maybe it should be non-nullable in the ITC schema?

@swalker2m
Copy link
Contributor

At some point, it was determined that SED should be optional and we've been suffering fallout from that change. See gemini-hlsw/lucuma-odb#272 for example.

@swalker2m
Copy link
Contributor

swalker2m commented Feb 27, 2023

I can make it refuse to call the ITC if the SED isn't available, but that code changes a lot in gemini-hlsw/lucuma-odb#268 so I'd prefer to do it there. We should then make it not optional in the ITC schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants