Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customMask bug #322

Open
swalker2m opened this issue Nov 7, 2022 · 1 comment
Open

customMask bug #322

swalker2m opened this issue Nov 7, 2022 · 1 comment

Comments

@swalker2m
Copy link
Contributor

swalker2m commented Nov 7, 2022

The fpu input for GmosNITCInput (and the one for the south as well) support optional customMask and builtin fields. The idea, I believe, is that either one or the other should be specified. If I send an input with customMask: null and builtin defined, I get an empty response. If I remove the customMask: null entry though, I get the expected results.

This happens in a test case. Unfortunately I can't run the ITC locally and it fails for some other reason in production so I cannot confirm this.

query {
  spectroscopy(input: {
    wavelength : {
      picometers : 1
    },
    signalToNoise : 1.0,
    sourceProfile : {
      point : {
        bandNormalized : {
          sed : {
            galaxy : SPIRAL
          },
          brightnesses : [
            {
              band: U,
              value: 15.0,
              units: VEGA_MAGNITUDE,
              error: 1.0
            }
          ]
        }
      }
    },
    band : SLOAN_U,
    radialVelocity : {
      metersPerSecond : 1.0
    },
    constraints : {
      imageQuality : POINT_ONE,
      cloudExtinction : POINT_ONE,
      skyBackground : DARKEST,
      waterVapor : VERY_DRY,
      elevationRange : {
        airMass : {
          min : 1.0,
          max : 2.0
        }
      }
    },
    modes : [
      {
        gmosN : {
          grating : B1200_G5301,
          fpu : {
            customMask: null,
            builtin : LONG_SLIT_0_25
          },
          filter : G_PRIME
        }
      }
    ]
  }) {
    results {
      itc {
        resultType
        ... on ItcError {
          msg
        }
      }
    }
  }
}
@swalker2m
Copy link
Contributor Author

It looks like customMask is not yet (?) supported:

https://github.com/gemini-hlsw/lucuma-itc/blob/main/modules/service/src/main/scala/lucuma/itc/service/ItcPartials.scala#L629-L651

Is the plan to add support for this or perhaps the client should not expose the possibility of sending a custom mask?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant