Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] New release to fix bugs in package manager installations #70

Closed
LucasPaoli opened this issue Jan 31, 2024 · 8 comments
Closed

[FEAT] New release to fix bugs in package manager installations #70

LucasPaoli opened this issue Jan 31, 2024 · 8 comments

Comments

@LucasPaoli
Copy link

Is your feature request related to a problem? Please describe.
The current release contains bugs that have been fixed in the main branch, e.g. #69.

Describe the solution you'd like
Creating a new minor release.

Describe alternatives you've considered
Either downloading from GitHub or fixing the code in the environment, none of which are suitable within workflow managers or SOPs.

Thank you

@jeanrjc
Copy link
Contributor

jeanrjc commented Jan 31, 2024

Yes ! @bneron it would be great if you could find the time to release the fix. It impacts users of DefenseFinder, and also users of software using defensefinder in their pipeline (e.g. weisberglab/beav#1).

Thanks

@mmolari
Copy link

mmolari commented Feb 1, 2024

Just wanted to add my voice as well. It would be super nice to have the fix in a new release for all of the downstream pipelines. Thanks for all of the hard work!

@LudoPoire
Copy link

LudoPoire commented Feb 1, 2024

Hi all, glad to know I'm not the only one having trouble with profiles.
I've had the exact same problem as in this post, has anyone found a way to fix this (without hacking the repositories.py source code) ? Or should we just wait until the next patch ? Thanks ! :)

@bneron
Copy link
Contributor

bneron commented Feb 2, 2024

this bug has been already fixed 27ee21c. just use the master version.

@LucasPaoli
Copy link
Author

Hi @bneron, I appreciate that the master version is updated and thank you very much for the fix.

However, I just wanted to reiterate that (as mentioned also by Jean and Marco), using the master version is not a viable option for downstream softwares, pipelines or SOPs that use macsyfinder as a dependency (e.g. through pip or conda).

Thank you again!

@bneron
Copy link
Contributor

bneron commented Feb 3, 2024

I wil do a new release at the end of february but I haven't any time right now to do it.

@jeanrjc
Copy link
Contributor

jeanrjc commented Feb 22, 2024

In the meantime, we released defensefinder (v1.2.2) with a previous version of macsyfinder that did not have the bug. We'll make another release when macsyfinder will be released.

@bneron
Copy link
Contributor

bneron commented Aug 6, 2024

I just released a new version of MacSyFinder ( https://github.com/gem-pasteur/macsyfinder/releases 2.1.4) that fix this bug
the new version is available on

@bneron bneron closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants