Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the failing tests in System.Console.Hawk.Args.Parse #198

Closed
gelisam opened this issue Nov 27, 2018 · 1 comment
Closed

Fix the failing tests in System.Console.Hawk.Args.Parse #198

gelisam opened this issue Nov 27, 2018 · 1 comment
Labels
Milestone

Comments

@gelisam
Copy link
Owner

gelisam commented Nov 27, 2018

No description provided.

@gelisam gelisam added this to the 1.1.2 milestone Nov 28, 2018
@gelisam
Copy link
Owner Author

gelisam commented Dec 4, 2018

Woah, this one is pretty weird. The failing doctest is in System.Console.Hawk.Args.Parse, but that test does not fail when I run doctest on System.Console.Hawk.Args.Parse, it only fails when I run doctest on System.Console.Hawk, which happens to cause doctest to also run the System.Console.Hawk.Args.Parse tests because System.Console.Hawk imports System.Console.Hawk.Args, which imports System.Console.Hawk.Args.Parse.

Since doctest is implemented by pasting all the tests into ghci one after the other, it's possible for one test to modify ghci's environment in a way which will cause later tests to fail. But I would only expect this if e.g. language extensions are enabled or something, I would not expect a pure function to suddenly return a different result!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant