Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the latest haskell-src-exts #136

Closed
gelisam opened this issue Feb 14, 2015 · 4 comments
Closed

Support the latest haskell-src-exts #136

gelisam opened this issue Feb 14, 2015 · 4 comments
Labels
Milestone

Comments

@gelisam
Copy link
Owner

gelisam commented Feb 14, 2015

That library has changed again, but this time it didn't break anything, it only added a few extra constructors:

Pattern match(es) are non-exhaustive
In an equation for ‘location’:
    Patterns not matched:
        ClosedTypeFamDecl _ _ _ _ _
        MinimalPragma _ _

I'm not fixing it right now because there is also the extra work of figuring out which new version bounds we need to put on our haskell-src-exts dependency.

@gelisam
Copy link
Owner Author

gelisam commented Feb 14, 2015

Since this seems to change relatively often, maybe we could find another way of extracting the line number? Maybe by creating an error string incorporating the location, and parsing that?

@gelisam gelisam modified the milestone: 1.2 Feb 17, 2015
@gelisam
Copy link
Owner Author

gelisam commented Jun 1, 2015

I see that I have added an upper bound on haskell-src-exts to hackage a while ago, but didn't actually change the .cabal file in HEAD. Doing this now.

@gelisam
Copy link
Owner Author

gelisam commented Jun 1, 2015

Wait, no, I'm confusing two separate issues here. The upper bound has been added to address #123, and HEAD has been adjusted to account for it, but requesting the latest version of haskell-src-exts. This issue is about a less important concern: a warning, not a compilation error.

@gelisam gelisam added the medium label Jul 19, 2015
@gelisam
Copy link
Owner Author

gelisam commented Jul 19, 2015

Closed in favor of the more permanent solution proposed in #149.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant