Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional json output format #35

Closed
anderejd opened this issue Dec 19, 2018 · 4 comments
Closed

Add optional json output format #35

anderejd opened this issue Dec 19, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@anderejd
Copy link
Contributor

--json or something similar.

@icefoxen
Copy link
Contributor

Related: #10

This would be nice for my side-project too; aim me at the right data structures and if/when I need this I'll implement it. Do we want this to be a feature flag so we don't always need to build serde, or is that fine?

@anderejd
Copy link
Contributor Author

anderejd commented Dec 19, 2018

aim me at the right data structures and if/when I need this I'll implement it.

All the functions related to printing the tree needs to be separated from the source code scanning, in particular this function needs some refocusing:
https://github.com/anderejd/cargo-geiger/blob/master/src/lib.rs#L829

When that separation is done the json feature should only require a bit of serde attribute sprinkling on top.

Do we want this to be a feature flag so we don't always need to build serde, or is that fine?

I think it's good to have it on by default, cargo-geiger already depends on serde and serde-json... and most of the remaining crates on crates.io.

@anderejd anderejd added the enhancement New feature or request label Dec 19, 2018
@stephaneyfx
Copy link
Contributor

Should this be closed given that #115 was merged?

@anderejd
Copy link
Contributor Author

Yes! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants