Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building without lockfile fails #175

Closed
Nemo157 opened this issue Jan 15, 2021 · 6 comments
Closed

Building without lockfile fails #175

Nemo157 opened this issue Jan 15, 2021 · 6 comments
Labels
bug Something isn't working important If you want to contribute, please consider this issue before others.

Comments

@Nemo157
Copy link

Nemo157 commented Jan 15, 2021

> cargo install cargo-geiger --git https://github.com/rust-secure-code/cargo-geiger --force
    Updating git repository `https://github.com/rust-secure-code/cargo-geiger`
  Installing cargo-geiger v0.10.2 (https://github.com/rust-secure-code/cargo-geiger#df452561)
    Updating crates.io index
...
   Compiling cargo-geiger v0.10.2 (/home/nemo157/.cargo/git/checkouts/cargo-geiger-2d6bf70f2d1911c6/df45256/cargo-geiger)
error[E0609]: no field `repr` on type `&Platform`
   --> cargo-geiger/src/graph.rs:157:59
    |
157 | ...                   (Platform::from_str(p.repr.as_str()))
    |                                             ^^^^

It looks like cargo-geiger is relying on internal details of cargo_metadata::Dependency::target that have changed in v0.12.2.

@anderejd
Copy link
Contributor

@jmcconnell26 Can you take a look at this? 🙏😃

@anderejd anderejd added bug Something isn't working important If you want to contribute, please consider this issue before others. labels Jan 19, 2021
@jmcconnell26
Copy link
Contributor

@anderejd, I've landed #178 which should fix the immediate issue.
On a slightly related note if cargo_metadata have released a new version of their library, that means the changes I made to their library here oli-obk/cargo_metadata#148 should also be available. This would allow us to clean up some of the workarounds I had to put in, I'll look at putting this in too.

@jmcconnell26
Copy link
Contributor

Long term I wonder if it might be possible to implement some sort of Canary CI/CD pipeline which attempts builds without lockfiles, to detect stuff like this, and give us at least some visibility into issues like this?

@anderejd
Copy link
Contributor

Long term I wonder if it might be possible to implement some sort of Canary CI/CD pipeline which attempts builds without lockfiles, to detect stuff like this, and give us at least some visibility into issues like this?

Sounds like a good idea. Should be fairly simple to add a second build to the CI scripts/configs.

@jmcconnell26
Copy link
Contributor

Raised #183 to perform a build without the lockfile, which should let us catch this in future.

@pinkforest
Copy link
Collaborator

Closing this as this was resolved - for the sake of completeness I've been using this as well :)

Re-open if replicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working important If you want to contribute, please consider this issue before others.
Projects
None yet
Development

No branches or pull requests

4 participants