Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives for the syn crate #11

Open
Tracked by #241
niklasf opened this issue Jun 26, 2018 · 3 comments
Open
Tracked by #241

False positives for the syn crate #11

niklasf opened this issue Jun 26, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@niklasf
Copy link

niklasf commented Jun 26, 2018

It looks like syn is particularly tricky. Looking at https://github.com/dtolnay/syn/search?p=1&q=unsafe&unscoped_q=unsafe I think there should be fewer real uses of unsafe:

Functions  Expressions  Impls  Traits  Methods  Dependency
0          25           1      0       2        ☢         └── syn v0.14.2
@anderejd
Copy link
Contributor

anderejd commented Jun 26, 2018

Thank you for the report!

It looks like the Impl and Methods metrics are accurate.

The Expressions are probably too high since tests and examples are included, but the "unsafe" string literals and comments are not included. cargo-geiger make use of the same crate, syn, for parsing .rs files.

Related to:
https://github.com/anderejd/cargo-geiger/issues/3

@niklasf
Copy link
Author

niklasf commented Jun 26, 2018

Ah, thank you. Then this is just a duplicate of #3.

@niklasf niklasf closed this as completed Jun 26, 2018
@anderejd
Copy link
Contributor

Created a new issue for filtering examples: https://github.com/anderejd/cargo-geiger/issues/12

@pinkforest pinkforest reopened this Jan 6, 2022
@pinkforest pinkforest added the bug Something isn't working label Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants