-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of soft dependency on geerlingguy.php role #35
Comments
I'd vote for just dropping the restart. I'd say the users requiring the opcache to clear is below the <20% use case and could just opt for a custom script and #34. Personally I do https://github.com/generoi/capistrano-tasks/blob/master/lib/capistrano/tasks/cache.rake#L42:L69 |
I'd say it's fine to drop the restart. Especially if we just document the issue, or do as suggested by @oxyc. Or instead of making a file, minify the line and pass to So
Tested this locally and seemed to work okay. |
Done! Thanks @mglaman |
Currently this role calls the
restart webserver
handler in thegeerlingguy.php
role when a Drupal deployment is completed, but this role shouldn't, since that role is not a hard dependency.In the PHP role, the handlers defined are:
We could either define our own handler(s), or figure out whether it's strictly necessary or not. I think the reason I had that in there initially was for the Raspberry Pi-based setup I tested on—I had opcache configured to not stat files on every page load since the files were on slow microSD cards... for most servers (and by default), since opcache is looking at each file, we technically don't need a hard restart of php-fpm to pick up changed files.
The text was updated successfully, but these errors were encountered: