Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build_coder_maps incompatible with Redshift #369

Closed
TSMMark opened this issue Feb 19, 2021 · 0 comments · Fixed by #370
Closed

build_coder_maps incompatible with Redshift #369

TSMMark opened this issue Feb 19, 2021 · 0 comments · Fixed by #370

Comments

@TSMMark
Copy link

TSMMark commented Feb 19, 2021 •
edited
Loading

cannot cast type regproc to character varying

#330 appears to break redshift. It doesn't like the ::text part. cannot cast type regproc to character varying

Here's an example of a commit in another project that removes ::text casting in order to support redshift. npgsql/npgsql@5c7f266

Monkeypatching this method to revert to the old implementation fixes the issue in our codebase.

Original comment #330 (comment)
@TSMMark TSMMark mentioned this issue Feb 19, 2021
Merged
larskanis added a commit to larskanis/ruby-pg that referenced this issue Feb 19, 2021
@larskanis
Avoid casting of OIDs to fix compat with Redshift database
365008e 
Redshift doesn't support OID these casts, so we do OID lookup through the pg_proc table and add type 'name' as an alias for 'text'.

Also clean up the type map generation, so that only arrays are separated and all other types can be registered.

Fixes ged#369
@larskanis larskanis mentioned this issue Feb 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid casting of OIDs to fix compat with Redshift database larskanis/ruby-pg
1 participant
@TSMMark