Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby 2.4 test failure #255

Closed
ged opened this issue Jan 10, 2017 · 1 comment
Closed

Ruby 2.4 test failure #255

ged opened this issue Jan 10, 2017 · 1 comment
Labels
0.19.0 bug Library major

Comments

@ged
Copy link
Owner

ged commented Jan 10, 2017

Original report by Vít Ondruch (Bitbucket: vo_x, ).

Hi,

Trying to build pg against Ruby 2.4 for Fedora, I observe one test failure:

  1) PG::TypeMapByClass should retrieve particular conversions
     Failure/Error: expect( tm[Bignum] ).to be_nil

       expected: nil
            got: #<PG::BinaryEncoder::Int8:0x0055e79af18038 "INT8"  oid=20 format=1>
     # ./spec/pg/type_map_by_class_spec.rb:62:in `block (2 levels) in <top (required)>'
     # ./spec/helpers.rb:29:in `block in included'

This is very likely caused by unification of Fixnum and Bignum in Ruby 2.4 (1).
@ged
Copy link
Owner Author

ged commented Jan 14, 2017

Original comment by Lars Kanis (Bitbucket: larskanis, GitHub: larskanis).

Bignum,Fixnum and Integer are the same in Ruby-2.4.

Fixes #255 : https://bitbucket.org/ged/ruby-pg/issues/255

@ged ged closed this as completed Jan 14, 2017
@ged ged added this to the Pending milestone Oct 8, 2019
cbandy pushed a commit to cbandy/ruby-pg that referenced this issue Jan 10, 2020
@larskanis
Bignum,Fixnum and Integer are the same in Ruby-2.4.
d268078 
Fixes ged#255 : https://bitbucket.org/ged/ruby-pg/issues/255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.19.0 bug Library major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ged