Make distcheck not working

[frlan]

with git ab5a451

make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/home/frlan/quellen/geany-plugins/geany-plugins-1.34/_inst/lib/geany'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   workbench.la '/home/frlan/quellen/geany-plugins/geany-plugins-1.34/_inst/lib/geany'
libtool: warning: relinking 'workbench.la'
libtool: install: (cd /home/frlan/quellen/geany-plugins/geany-plugins-1.34/_build/sub/workbench/src; /bin/bash "/home/frlan/quellen/geany-plugins/geany-plugins-1.34/_build/sub/libtool"  --silent --tag CC --mode=relink gcc -DLOCALEDIR=\"/home/frlan/quellen/geany-plugins/geany-plugins-1.34/_inst/share/locale\" -DPREFIX=\"/home/frlan/quellen/geany-plugins/geany-plugins-1.34/_inst\" -DDOCDIR=\"/home/frlan/quellen/geany-plugins/geany-plugins-1.34/_inst/share/doc/geany-plugins\" -DGEANYPLUGINS_DATADIR=\"/home/frlan/quellen/geany-plugins/geany-plugins-1.34/_inst/share\" -DPKGDATADIR=\"/home/frlan/quellen/geany-plugins/geany-plugins-1.34/_inst/share/geany-plugins\" -DLIBDIR=\"/home/frlan/quellen/geany-plugins/geany-plugins-1.34/_inst/lib\" -DPKGLIBDIR=\"/home/frlan/quellen/geany-plugins/geany-plugins-1.34/_inst/lib/geany-plugins\" -DPLUGINDATADIR=\"/home/frlan/quellen/geany-plugins/geany-plugins-1.34/_inst/share/geany-plugins/workbench\" -DPLUGINDOCDIR=\"/home/frlan/quellen/geany-plugins/geany-plugins-1.34/_inst/share/doc/geany-plugins/workbench\" -DPLUGINLIBDIR=\"/home/frlan/quellen/geany-plugins/geany-plugins-1.34/_inst/lib/geany-plugins/workbench\" -DPLUGIN=\"workbench\" -DGTK -pthread -I/usr/local/include/geany -I/usr/local/include/geany/tagmanager -I/usr/local/include/geany/scintilla -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wall -Wimplicit-function-declaration -Wmissing-parameter-type -Wold-style-declaration -Wpointer-arith -Wshadow -Wundef -Wwrite-strings -I../../../../utils/src -g -O2 -module -avoid-version -no-undefined -Wl,-z,defs -o workbench.la -rpath /home/frlan/quellen/geany-plugins/geany-plugins-1.34/_inst/lib/geany workbench_la-plugin_main.lo workbench_la-wb_globals.lo workbench_la-workbench.lo workbench_la-wb_project.lo workbench_la-wb_monitor.lo workbench_la-dialogs.lo workbench_la-menu.lo workbench_la-popup_menu.lo workbench_la-sidebar.lo workbench_la-utils.lo -L/usr/local/lib -lgeany -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lfontconfig -lfreetype -lglib-2.0 ../../utils/src/libgeanypluginutils.la )
.libs/workbench_la-wb_project.o: In function `wb_project_dir_remove_file':
/home/frlan/quellen/geany-plugins/geany-plugins-1.34/_build/sub/workbench/src/../../../../workbench/src/wb_project.c:701: undefined reference to `gp_filelist_filepath_matches_patterns'
.libs/workbench_la-wb_project.o: In function `wb_project_dir_add_file_int':
/home/frlan/quellen/geany-plugins/geany-plugins-1.34/_build/sub/workbench/src/../../../../workbench/src/wb_project.c:584: undefined reference to `gp_filelist_filepath_matches_patterns'
collect2: error: ld returned 1 exit status
libtool:   error: error: relink 'workbench.la' with the above command before installing it
Makefile:600: recipe for target 'install-geanypluginsLTLIBRARIES' failed
make[4]: *** [install-geanypluginsLTLIBRARIES] Error 1
make[4]: Leaving directory '/home/frlan/quellen/geany-plugins/geany-plugins-1.34/_build/sub/workbench/src'
Makefile:851: recipe for target 'install-am' failed
make[3]: *** [install-am] Error 2
make[3]: Leaving directory '/home/frlan/quellen/geany-plugins/geany-plugins-1.34/_build/sub/workbench/src'
Makefile:583: recipe for target 'install-recursive' failed
make[2]: *** [install-recursive] Error 1
make[2]: Leaving directory '/home/frlan/quellen/geany-plugins/geany-plugins-1.34/_build/sub/workbench'
Makefile:627: recipe for target 'install-recursive' failed
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory '/home/frlan/quellen/geany-plugins/geany-plugins-1.34/_build/sub'
Makefile:832: recipe for target 'distcheck' failed
make: *** [distcheck] Error 1

[lpaulsen93]

I checked out the current master and ran make distcheck. I got some issues with plugin multiterm but I could fix that by installing valac. After that is fixed I now get the output:

====================================================
geany-plugins-1.34 archives ready for distribution: 
geany-plugins-1.34.tar.gz
geany-plugins-1.34.tar.bz2
====================================================

I assume that means it worked fine. Did you try a fresh make clean / ./autogen.sh / make / make install / make distcheck?

[frlan]

Yes, you are right. Looks like an autotools fuckup on layer 8 on my side. Mea culpa

[lpaulsen93]

Never mind.