Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
멋지다멋지다 멋져 |
|
|
shon5544
reviewed
May 13, 2024
Comment on lines
51
to
53
| public List<ShortenedUrlDto> getShortUrlsContainingStringQueryDsl(String inquiry) { | ||
| List<ShortenedUrl> shortUrls = shortenedUrlRepository.findByOriginUrlContaining(inquiry); | ||
| return shortUrls.stream().map(ShortenedUrlDto::from).collect(Collectors.toList()); |
There was a problem hiding this comment.
해당부분 dsl 코드는 어니고 아직 JpaRepository 관련 코드인 것 같은데요! 해당 부분만 고치면 괜찮을 것 같아요 ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
Check List
main브랜치의 최신 상태를 반영하고 있는지 확인Screenshot