Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when counting points in point cloud #13

Open
dgriffiths3 opened this issue Apr 2, 2021 · 4 comments
Open

Error when counting points in point cloud #13

dgriffiths3 opened this issue Apr 2, 2021 · 4 comments

Comments

@dgriffiths3
Copy link

dgriffiths3 commented Apr 2, 2021

In the examples/groundtruth_extraction.py example script there is a small bug. The matrix you get at Line 71 does not take into account the height, width, length should be divided by 2 as it is from the center of the object. The resulting boxes are 2x the size they should be and therefore the mask obtained includes points that are not part of the object.

Changing:
sl, sh, sw = box.length, box.height, box.width to
sl, sh, sw = box.length/2., box.height/2., box.width/2.

in the utils. get_box_transformation_matrix fixes the problem in this instance but maybe that breaks the function for other uses?

@gdlg
Copy link
Owner

gdlg commented Apr 4, 2021

Thanks for reporting the issue. I am not currently actively using the dataset, so I am not able to test the proposed fix; however, your observation sounds correct. Feel free to create a PR and I can merge it.

@xiongyiheng
Copy link

Hello, will simply changing the codes as @dgriffiths3 does make the whole thing correct? I am using pytorch and I am struggling when loading waymo dataset. So this is actually the original issue. So if possible, could u plz share some ideas with me?

@dgriffiths3
Copy link
Author

Hi, it worked in my case, but I was only using it for the task of counting the points. I was planning to do a PR but haven't found time to check it won't break other functions.

@xiongyiheng
Copy link

Thanks for your reply. @dgriffiths3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants