Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unconventional use of floating action button #23

Closed
not-much-io opened this issue Oct 29, 2015 · 1 comment
Closed

Unconventional use of floating action button #23

not-much-io opened this issue Oct 29, 2015 · 1 comment
Assignees
@oscarmcm
Labels
bug enhancement
Milestone
jekyll-mdl 2.0 ve...

Comments

@not-much-io
Copy link

Using a floating action button on each card (as on demo page) is a discouraged practice by MD standards. :)

"Only one floating action button is recommended per screen to increase its prominence. It should represent only the most common action."

Source: https://www.google.de/design/spec/components/buttons-floating-action-button.html#buttons-floating-action-button-floating-action-button

A fix would be to simply use a second link on the card as in the first example here -> http://materializecss.com/cards.html
@oscarmcm oscarmcm added this to the jekyll-mdl 2.0 version milestone Oct 29, 2015
@oscarmcm oscarmcm self-assigned this Oct 29, 2015
oscarmcm added a commit that referenced this issue Oct 31, 2015
@oscarmcm
JKM-23 fix Unconventional use of floating action button
f09da58 
Remove floating action buttons from cards. See #23 for more details
@oscarmcm oscarmcm mentioned this issue Oct 31, 2015
Merged
@oscarmcm
Copy link
Member

Fixed in #24 thanks @not-much-io 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oscarmcm oscarmcm

Labels
bug enhancement
Projects
None yet
Milestone
jekyll-mdl 2.0 version
Development

No branches or pull requests
2 participants
@oscarmcm @not-much-io