Fix read!(s::IO, a::Vector{UInt8}) to return a

lost in JuliaLang#12839
gdevanla · Oct 3, 2015 · 010df39 · 010df39
1 parent 19563a3
commit 010df39
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/base/io.jl b/base/io.jl
@@ -129,6 +129,7 @@ function read!(s::IO, a::Vector{UInt8})
     for i in 1:length(a)
         a[i] = read(s, UInt8)
     end
+    return a
 end
 
 function read!{T}(s::IO, a::Array{T})

diff --git a/test/core.jl b/test/core.jl
@@ -3401,3 +3401,8 @@ b8932 = Vec3_8932(2,2,2)
 f13261() = (x = (error("oops"),); +(x...))
 g13261() = f13261()
 @test_throws ErrorException g13261()
+
+#13433, read!(::IO, a::Vector{UInt8}) should return a
+type IO13433 <: IO end
+Base.read(::IO13433, ::Type{UInt8}) = 0x01
+@test read!(IO13433(), Array(UInt8, 4)) == [0x01, 0x01, 0x01, 0x01]