Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication by API token, not parameter passing #76

Closed
18 tasks
skasberger opened this issue Jan 29, 2021 · 3 comments
Closed
18 tasks

Authentication by API token, not parameter passing #76

skasberger opened this issue Jan 29, 2021 · 3 comments
Assignees
Labels
pkg:api api related activities prio:medium status:confirmed Is a valid issue and will be moved forward soon. type:feature New feature

Comments

@skasberger
Copy link
Member

Authentication is done by passing an API token to the class instantiation, not by passing the parameter auth to the API methods.

Remove auth and establish set of API token if passed.

Prepare

  • Get all effected functions
    • get_request() ??
    • post_request() ??
    • delete_request() ??
    • put_request() ??

Actions

  • Develop tests
  • Remove auth from API methods
  • Update request methods, so they use the member-variable api_token if set and pass it to the request function
    • get_request() ??
    • post_request() ??
    • delete_request() ??
    • put_request() ??
  • [ ]Update Docs
  • Update Docstrings
  • Run pytest
  • Run tox
  • Run pylint
  • Run mypy

Review

  • Docs

Follow-Ups

  • [ ]
@skasberger skasberger added the status:incoming Newly created issue to be forwarded label Jan 29, 2021
@skasberger skasberger self-assigned this Feb 15, 2021
@skasberger skasberger added pkg:api api related activities prio:medium status:confirmed Is a valid issue and will be moved forward soon. type:feature New feature and removed status:incoming Newly created issue to be forwarded labels Feb 15, 2021
@skasberger skasberger added this to the v0.4.0 milestone Feb 15, 2021
@skasberger skasberger mentioned this issue Mar 14, 2021
35 tasks
@pdurbin
Copy link
Member

pdurbin commented Feb 14, 2024

As discussed during the 2024-02-14 meeting of the pyDataverse working group, we are closing old milestones in favor of a new project board at https://github.com/orgs/gdcc/projects/1 and removing issues (like this one) from those old milestones. Please feel free to join the working group! You can find us at https://py.gdcc.io and https://dataverse.zulipchat.com/#narrow/stream/377090-python

@pdurbin pdurbin removed this from the v0.4.0 milestone Feb 14, 2024
@shoeffner
Copy link
Collaborator

I accidentally found this issue now, and it seems to be the same as #192, which has a PR at #201.

@pdurbin
Copy link
Member

pdurbin commented Jul 22, 2024

Yes, thanks. I'll close this in favor of the newer issue and PR.

@pdurbin pdurbin closed this as completed Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:api api related activities prio:medium status:confirmed Is a valid issue and will be moved forward soon. type:feature New feature
Projects
None yet
Development

No branches or pull requests

3 participants