Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build to run on AWS Lambda Java 11, and for Trino with Java 17 #438

Closed
patchwork01 opened this issue Dec 12, 2022 · 4 comments · Fixed by #470
Closed

Build to run on AWS Lambda Java 11, and for Trino with Java 17 #438

patchwork01 opened this issue Dec 12, 2022 · 4 comments · Fixed by #470
Assignees
Milestone

Comments

@patchwork01
Copy link
Collaborator

patchwork01 commented Dec 12, 2022

We'd like to target Java 11 for AWS Lambda, and upgrade our Lambda deployments to use Java 11. This is because Lambda doesn't support Java 17 yet.

For code not deployed on Lambda, we can upgrade the deployment to use Java 17. Trino requires Java 17, so we'll need to build with that as well: #55

We'd also like to update all our Maven dependencies. We should probably split that out as a separate issue.

If there are any specific problems with any of the upgrades, it'd be good to raise those as separate issues.

We need to figure out whether to run separate builds or separate target versions, in order to both run on Java 11 for Lambda, and to build the Trino plugin for Java 17 as well.

We also need to update all the Docker images to use a later Java version.

@patchwork01 patchwork01 added this to the 0.14.0 milestone Dec 12, 2022
@patchwork01 patchwork01 changed the title Upgrade to Java 17 Build with Java 17 Dec 12, 2022
@gaffer01 gaffer01 changed the title Build with Java 17 Make the Java 11 the default version and ensure can build with Java 11 and 17 Dec 12, 2022
@patchwork01
Copy link
Collaborator Author

patchwork01 commented Jan 3, 2023

Here's some information about how the source and target compiler options work:

https://www.baeldung.com/java-source-target-options

It looks simpler to run two builds on different JDKs, though it might be easier to configure Maven if we avoid separate builds. Having some Maven modules building with different JDKs sounds like it would be difficult without these options.

This article has information about a new option to do this more simply, including Maven configuration:

https://www.baeldung.com/java-compiler-release-option

@patchwork01 patchwork01 changed the title Make the Java 11 the default version and ensure can build with Java 11 and 17 Build to run on AWS Lambda Java 11, and also to work with Trino which requires Java 17 Jan 3, 2023
@patchwork01 patchwork01 changed the title Build to run on AWS Lambda Java 11, and also to work with Trino which requires Java 17 Build to run on AWS Lambda Java 11, and for Trino with Java 17 Jan 3, 2023
@patchwork01
Copy link
Collaborator Author

AWS Lambda is due to add a base image for Java 17 any time now. They said they were working on it in November:

aws/aws-lambda-base-images#29

@kr565370
Copy link
Collaborator

kr565370 commented Jan 3, 2023

@patchwork01
Copy link
Collaborator Author

We need to pick a distribution, and it needs to be supported by GitHub Actions:

https://github.com/actions/setup-java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants