-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build to run on AWS Lambda Java 11, and for Trino with Java 17 #438
Comments
Here's some information about how the source and target compiler options work: https://www.baeldung.com/java-source-target-options It looks simpler to run two builds on different JDKs, though it might be easier to configure Maven if we avoid separate builds. Having some Maven modules building with different JDKs sounds like it would be difficult without these options. This article has information about a new option to do this more simply, including Maven configuration: |
AWS Lambda is due to add a base image for Java 17 any time now. They said they were working on it in November: |
Documentation for the maven compiler plugin: https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-source-and-target.html |
We need to pick a distribution, and it needs to be supported by GitHub Actions: |
We'd like to target Java 11 for AWS Lambda, and upgrade our Lambda deployments to use Java 11. This is because Lambda doesn't support Java 17 yet.
For code not deployed on Lambda, we can upgrade the deployment to use Java 17. Trino requires Java 17, so we'll need to build with that as well: #55
We'd also like to update all our Maven dependencies. We should probably split that out as a separate issue.
If there are any specific problems with any of the upgrades, it'd be good to raise those as separate issues.
We need to figure out whether to run separate builds or separate target versions, in order to both run on Java 11 for Lambda, and to build the Trino plugin for Java 17 as well.
We also need to update all the Docker images to use a later Java version.
The text was updated successfully, but these errors were encountered: